Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover triggers #531

Merged
merged 4 commits into from Mar 9, 2021
Merged

Popover triggers #531

merged 4 commits into from Mar 9, 2021

Conversation

tcbegley
Copy link
Collaborator

@tcbegley tcbegley commented Mar 7, 2021

This PR adds support for different popover triggers along with some documentation. It supercedes #530

danielgccr and others added 3 commits March 5, 2021 12:46
I propose the adding of a new proptype called Trigger, neccesary for closing a popover outside of its box.
@tcbegley
Copy link
Collaborator Author

tcbegley commented Mar 7, 2021

This can be tried with

pip install dash-bootstrap-components==0.11.4rc2

Here's a minimal example to try out

import dash
import dash_bootstrap_components as dbc

app = dash.Dash(external_stylesheets=[dbc.themes.BOOTSTRAP])

app.layout = dbc.Container(
    [
        dbc.Button("Click", id="click", className="mr-1"),
        dbc.Popover(
            [
                dbc.PopoverHeader("Header"),
                dbc.PopoverBody("This is a click popover"),
            ],
            id="click-popover",
            target="click",
            trigger="click",
        ),
        dbc.Button("Focus", id="focus", className="mr-1"),
        dbc.Popover(
            [
                dbc.PopoverHeader("Header"),
                dbc.PopoverBody("This is a focus popover"),
            ],
            id="focus-popover",
            target="focus",
            trigger="focus",
        ),
        dbc.Button("Hover", id="hover", className="mr-1"),
        dbc.Popover(
            [
                dbc.PopoverHeader("Header"),
                dbc.PopoverBody("This is a hover popover"),
            ],
            id="hover-popover",
            target="hover",
            trigger="hover",
        ),
        dbc.Button("Legacy", id="legacy", className="mr-1"),
        dbc.Popover(
            [
                dbc.PopoverHeader("Header"),
                dbc.PopoverBody("This is a legacy popover"),
            ],
            id="legacy-popover",
            target="legacy",
            trigger="legacy",
        ),
    ],
    className="p-5",
)


if __name__ == "__main__":
    app.run_server(debug=True)

@danielgccr it would be great if you could try this out and see if it adds the functionality you wanted.

@danielgccr
Copy link
Contributor

Yes, I tried this example. Works as expected and, yep, that's the desired function, great! Thanks.

@tcbegley tcbegley merged commit 4b01ac8 into main Mar 9, 2021
@tcbegley tcbegley deleted the popover-triggers branch March 9, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants