Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add select form feedback #755

Merged
merged 3 commits into from
Nov 14, 2021
Merged

Add select form feedback #755

merged 3 commits into from
Nov 14, 2021

Conversation

glsdown
Copy link
Contributor

@glsdown glsdown commented Oct 27, 2021

Issue raised #753 which identified that the valid and invalid props were not being passed correctly to the underlying component. This is because react-bootstrap uses isInvalid and isValid instead.

This resolves this issue.

@tcbegley
Copy link
Collaborator

Thanks! Could you add unit tests so we don't break this again?

@glsdown
Copy link
Contributor Author

glsdown commented Oct 27, 2021

Done!

@tcbegley tcbegley merged commit e45113b into main Nov 14, 2021
@tcbegley tcbegley deleted the select-form-feedback branch November 14, 2021 20:44
This was referenced Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants