Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caret prop of DropdownMenu #804

Merged
merged 1 commit into from Feb 5, 2022
Merged

Fix caret prop of DropdownMenu #804

merged 1 commit into from Feb 5, 2022

Conversation

tcbegley
Copy link
Collaborator

@tcbegley tcbegley commented Feb 5, 2022

This prop was having no effect after migration to react-bootstrap. cf. #792.

react-bootstrap doesn't actually expose this as an option, so the solution is to vendor react-bootstrap/DropdownToggle and make some minor changes.

@tcbegley tcbegley merged commit 2db90db into main Feb 5, 2022
@tcbegley tcbegley deleted the dropdown-caret branch February 5, 2022 07:59
This was referenced Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant