Add Accordion always_open property #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tcbegley - R and JL tests for the new accordion callback are failing ( |
tcbegley
force-pushed
the
accordion-always-open
branch
from
e5d4d1d
to
a083821
Compare
…trap-components into accordion-always-open
|
@tcbegley - due to the fact that |
tcbegley
approved these changes
Apr 3, 2022
Merged
Merged
tcbegley
added a commit
that referenced
this pull request
Apr 3, 2022
* Bump react-bootstrap version * Add always_open prop to Accordion * Add js tests for Accordion always_open * Add always_open to Accordion docs * Add always_open callback doc test * Remove unnecessary imports * Add callback file to flake8 ignore files * Call the second callback test * Bump react-bootstrap version * Add always_open prop to Accordion * Add js tests for Accordion always_open * Add always_open to Accordion docs * Add always_open callback doc test * Remove unnecessary imports * Add callback file to flake8 ignore files * Call the second callback test * Fix some issues with tests * Remove always_open example in R * Clean up Accordion source * Fix accordion tests * Remove note about R * Revert debugging change to tests Co-authored-by: tcbegley <tomcbegley@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in issue #834 I've added support for
always_openproperty of the Bootstrap 5 Accordion. This includes:I have additionally bumped the react-bootstrap version.