Forward undefined to target props instead of bool #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmijos
commented
Jul 13, 2022
|
Thanks @schmijos, it will be a week or so before I can look at this properly, but I appreciate you taking the time to submit! |
_react-dom_ complains with a warning if it receives booleans for non-boolean DOM properties (see <https://github.com/facebook/react/blob/main/packages/react-dom/src/shared/ReactDOMUnknownPropertyHook.js#L186-L190>). This passes `undefined` to the `target` props instead of `false to fix the warning.
schmijos
force-pushed
the
fix-bool-attr-warning
branch
from
f8240c9 to
2b80428
Compare
schmijos
commented
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-dom complains with a warning if it receives booleans for non-boolean DOM properties (see https://github.com/facebook/react/blob/main/packages/react-dom/src/shared/ReactDOMUnknownPropertyHook.js#L186-L190).
This passes
undefinedto thetargetprops instead of `false to fix the warning.