Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Placeholder component #899

Merged
merged 5 commits into from
Dec 28, 2022
Merged

Add new Placeholder component #899

merged 5 commits into from
Dec 28, 2022

Conversation

glsdown
Copy link
Contributor

@glsdown glsdown commented Oct 16, 2022

As per #844 I have added the new Placeholder component. I have implemented it slightly differently to the React-Bootstrap component, using a button flag rather than a separate component.

Copy link
Collaborator

@tcbegley tcbegley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@tcbegley tcbegley merged commit 1c430ae into facultyai:main Dec 28, 2022
@tcbegley tcbegley deleted the placeholder branch December 28, 2022 10:55
This was referenced Dec 28, 2022
tcbegley added a commit that referenced this pull request Dec 28, 2022
* Add Placeholder component and js tests

* Add Placeholder docs

* Fix issue with animation not showing

* Add placeholder to theme explorer

Co-authored-by: Tom Begley <tomcbegley@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants