Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Support for .h files, and support for UIBarButtonItem customView #13

Merged
merged 3 commits into from Mar 27, 2013

Conversation

Projects
None yet
3 participants

No description provided.

Contributor

wbyoung commented Mar 27, 2013

Thanks for the contribution, it looks good! Is there a reason that you've added logging to the strings file creation? Was it for debugging or did you just want the more verbose output?

I was just trying to verify that my .h files were in fact being processed. I didn't mean to leave it in there. I can recommit without it if you'd like.

Thanks for the library, by the way. I was using a self-built solution that did something similar, but was nowhere near as elegant or complete.

Contributor

wbyoung commented Mar 27, 2013

Yea, let's take it out. Otherwise, everything else looks good!

Ok, I committed removal of the logging. Do you need a new pull request?

@wbyoung wbyoung added a commit that referenced this pull request Mar 27, 2013

@wbyoung wbyoung Merge pull request #13 from DinosaurDad/master
Support for .h files, and support for UIBarButtonItem customView
d163573

@wbyoung wbyoung merged commit d163573 into fadingred:master Mar 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment