suggest-term: search for terms returns null pointer exception #70

Merged
merged 7 commits into from Jan 25, 2013

Conversation

Projects
None yet
3 participants
Contributor

sparkica commented Jan 24, 2013

OpenRefine was updated to Freebase Suggest 4.0 API and now /command/rdf-extension/suggest-term returns null pointer exception, so adding properties in Edit RDF schema does not work (error: Sorry, something went wrong. Please try again later)

fadmaa added a commit that referenced this pull request Jan 25, 2013

Merge pull request #70 from sparkica/fix_search_term
suggest-term: search for terms returns null pointer exception

@fadmaa fadmaa merged commit 684b4ec into fadmaa:master Jan 25, 2013

Things still does not work properly.

In version 0.8.0, the suggestions are different for types and predicates.

Now the suggestions only provide types, whether I try to add a type or a predicate, i.e there are suggestions for rdfs:Literal but no suggestion for rdfs:label, regardless.

Side note to @sparkica : Can you please enable the 'Issues' part of your forked repos? I have some suggestions and errors to discuss.

Contributor

sparkica commented Feb 13, 2013

Hi Frode, issues on my fork enabled. I'll take a look at the problem with types/predicates ASAP.

Contributor

sparkica commented Feb 15, 2013

@frodeseverin: A pull request for fixing suggesting properties was created - see #77. It is already merged on my fork and it works now for successfully imported vocabularies.

@fadmaa do you plan to merge? :)

Confirmed to work; I cloned @sparkica 's fork.

@sparkica : Thank you much

Contributor

sparkica commented Feb 15, 2013

@frodeseverin You're welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment