Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country Detection broken #3

Closed
IDragonfire opened this issue Nov 4, 2014 · 4 comments
Closed

Country Detection broken #3

IDragonfire opened this issue Nov 4, 2014 · 4 comments

Comments

@IDragonfire
Copy link
Contributor

http://forums.faforever.com/forums/viewtopic.php?f=2&t=8827#p85146

Allow player country override?
(In my opinion no: https://faforever.slack.com/archives/general/p1415097597000084)

Update GeoIp database?

@IDragonfire
Copy link
Contributor Author

Maybe that?
http://freegeoip.net/
Sources:
https://github.com/fiorix/freegeoip

@Sheeo
Copy link
Member

Sheeo commented Nov 5, 2014

Yeah that looks good. The db updater script is even written in python, so it'll be trivial to just run on the server and use sqlite to grab the data.

@IDragonfire
Copy link
Contributor Author

The database behind is http://www.maxmind.com/
But it should be better then the current solution ;)

Maybe we can download the database directly:
http://dev.maxmind.com/geoip/legacy/geolite/

@Sheeo
Copy link
Member

Sheeo commented Feb 26, 2015

As it turned out, this was the same database we already used -- I've replaced the geoip implementation with one from PyPi on develop.

@Sheeo Sheeo closed this as completed Feb 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants