Fixed directly defined banaction for allports jails like pam-generic, recidive, etc #1238
Conversation
… recidive, etc with new default variable `banaction_allports` (+ man entries for both variables added); closes fail2bangh-1216
Fixed directly defined banaction for allports jails like pam-generic, recidive, etc
| @@ -146,6 +146,12 @@ Ensure syslog or the program that generates the log file isn't configured to com | |||
| .B logencoding | |||
| encoding of log files used for decoding. Default value of "auto" uses current system locale. | |||
| .TP | |||
| .B banaction | |||
| default banning action (iptables-multiport) for all jails specified in the \fI[DEFAULT]\fR section. | |||
There was a problem hiding this comment.
Default section doesn't have jails. Jails are all other sections and default one just provides defaults
There was a problem hiding this comment.
Yes, but I meant: the banning action (for all jails) specified in the [DEFAULT] section.
Not the jails in default section. My bad english :(
There was a problem hiding this comment.
It could also be specified per jail. Again, DEFAULTS are just defaults. So no need to state where it is since it can be anywhere
On October 31, 2015 10:18:58 AM EDT, "Serg G. Brester" notifications@github.com wrote:
@@ -146,6 +146,12 @@ Ensure syslog or the program that generates the
log file isn't configured to com
.B logencoding
encoding of log files used for decoding. Default value of "auto"
uses current system locale.
.TP
+.B banaction
+default banning action (iptables-multiport) for all jails specified
in the \fI[DEFAULT]\fR section.Yes, but I meant: the banning action (for all jails) specified in the
[DEFAULT]section.
Not the jails in default section. My bad english :(
Reply to this email directly or view it on GitHub:
https://github.com/fail2ban/fail2ban/pull/1238/files#r43572222
There was a problem hiding this comment.
Yes I know, but point of this commit resp. of this variables to specify it central in [DEFAULT] section of jail.local, just to not specify it per jail.
Also one place for all "normal" jails and one for "allports" jails...
There was a problem hiding this comment.
Yes. But my comment is about documentation. Now it is misleading and needs to be fixed up.
On October 31, 2015 11:08:46 AM EDT, "Serg G. Brester" notifications@github.com wrote:
@@ -146,6 +146,12 @@ Ensure syslog or the program that generates the
log file isn't configured to com
.B logencoding
encoding of log files used for decoding. Default value of "auto"
uses current system locale.
.TP
+.B banaction
+default banning action (iptables-multiport) for all jails specified
in the \fI[DEFAULT]\fR section.Yes I know, but point of this commit resp. of this variables to specify
it central in [DEFAULT] section ofjail.local, just to not specify it
per jail.
Also one place for all "normal" jails and one for "allports" jails...
Reply to this email directly or view it on GitHub:
https://github.com/fail2ban/fail2ban/pull/1238/files#r43572728
There was a problem hiding this comment.
Now it is misleading
Now it is available (before it was at all not documented) ... but I've corrected my "mistake" in 5767191.
Fixed directly defined banaction for allports jails like pam-generic, recidive, etc with new default variable
banaction_allports(+ man entries for both variables added);closes gh-1216