Dealing with dangling symlinks -- avoid adding those files to server for monitoring #369

Merged
merged 2 commits into from Sep 30, 2013

Projects

None yet

3 participants

@yarikoptic
Fail2Ban member

This is more of a workaround, then a complete solution but I think it already should be better than nothing.

In future might need more harness in the server to not crash if some file goes missing, etc.

Originally reported on the mailing list http://sourceforge.net/mailarchive/message.php?msg_id=31455385

yarikoptic added some commits Sep 29, 2013
@yarikoptic yarikoptic TST: that we do receive IOError if trying to feed broken symlink into…
… path to be monitored by server
cf76019
@yarikoptic yarikoptic BF: do not pass dangling symlinks to the server to be monitored
This is more of a workaround I guess than a "solution".  Ideally server
should be more clever and allow adding symlinks which eventually might
point to existing file.  But that is probably would be too much complication
for a rare use case.  User on the mailing list informed that then server
does not monitor even other files, thus as a quick workaround -- do not even add dangling links
dcaacad
@coveralls

Coverage Status

Coverage remained the same when pulling dcaacad on yarikoptic:master into e12d389 on fail2ban:master.

@grooverdan

looks fine too me.

@yarikoptic yarikoptic merged commit c772833 into fail2ban:master Sep 30, 2013

1 check passed

Details default The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment