Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TxPower control with 0x0806 command / Get TxPower should be made available too #145

Closed
pipiche38 opened this issue Feb 11, 2019 · 10 comments

Comments

@pipiche38
Copy link

commented Feb 11, 2019

In regards to set TxPower , it would be convenient to have get TxPower as well

@pipiche38

This comment has been minimized.

Copy link
Author

commented Feb 18, 2019

@fairecasoimeme

Could you clarify what are the expected value for the TXPower command ?

Is that a value between 0 and 0xbf ?
If 0x80 the default value ?

@pipiche38

This comment has been minimized.

Copy link
Author

commented Feb 19, 2019

Quel devrait etre le résultat attendu de l'utilisation du TX Power ?

Est-ce les bonnes valeurs ?

@pipiche38

This comment has been minimized.

Copy link
Author

commented Feb 19, 2019

BTW, while going to the source code, if I'm not mistaken,
this Command is always return SUCCESS!!! Looks like the return of eAppApiPlmeSet functions is not taken in consideration. a PHY_Enum_e enumeration status value to indicate success or failure of the operation.


        if (1 == u16PacketLength)
        {
                u8TxPower = pu8LinkRxBuffer[ u32BytesRead ];
                u32BytesRead += sizeof(u8TxPower);

                eAppApiPlmeSet(PHY_PIB_ATTR_TX_POWER, u8TxPower);
                *peAHIStatus = E_AHI_SUCCESS;
        }

@pipiche38

This comment has been minimized.

Copy link
Author

commented Mar 15, 2019

What is the expected impact of this 3.0f parameter ?

@ISO-B ISO-B self-assigned this Mar 15, 2019

@ISO-B

This comment has been minimized.

Copy link
Collaborator

commented Mar 15, 2019

I am currently changing command to return something else than always success. Also adding Get TxPower command.

@ISO-B ISO-B added this to the v3.1a milestone Mar 15, 2019

@pipiche38

This comment has been minimized.

Copy link
Author

commented Mar 15, 2019

Great. And what about the correct values :
Is that a value between 0 and 0xbf ?
If 0x80 the default value ?

@ISO-B

This comment has been minimized.

Copy link
Collaborator

commented Mar 15, 2019

That seems correct based on NXP IEEE 802.15.4 Stack User Guide (JN-UG-3024 v2.6) Table 10

PHY_PIB_TX_POWER_DEF (default - 0x80)
PHY_PIB_TX_POWER_MIN (minimum - 0)
PHY_PIB_TX_POWER_MAX (maximum - 0xbf)
@ISO-B

This comment has been minimized.

Copy link
Collaborator

commented Mar 27, 2019

This should now work on v3.1a

@ISO-B ISO-B closed this Mar 27, 2019

@pipiche38

This comment has been minimized.

Copy link
Author

commented Jun 21, 2019

confirmed

@fairecasoimeme fairecasoimeme referenced this issue Jul 12, 2019
@aztazt

This comment has been minimized.

Copy link

commented Aug 9, 2019

Am I supposed to see a Get TX button in the TestGUI_Zigate software ? Sorry, I'm new to zigbee.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.