Fix 24 bits types handling#290
Merged
fairecasoimeme merged 1 commit intofairecasoimeme:v3.1dfrom May 6, 2020
badzz:write24bit
Merged
Fix 24 bits types handling#290fairecasoimeme merged 1 commit intofairecasoimeme:v3.1dfrom badzz:write24bit
fairecasoimeme merged 1 commit intofairecasoimeme:v3.1dfrom
badzz:write24bit
Conversation
It is stored in a 32 bits C type but we copy into a 32 bits array for sending which is wrong. Code is changed to copy into 24bits structure Further fixing would include sending back a shorter length as the function sends back 4 bytes length instead of 3 bytes. I suspect the other structure like 40bits and 56bits have the same issue Orignal issue was that when sending 0x123456 was ending up as 0x345600 on the zigbee sniffer
Owner
|
ok great ! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is stored in a 32 bits C type but we copy into a 32 bits array for sending which is wrong. Code is changed to copy into 24bits structure
Further fixing would include sending back a shorter length as the function sends back 4 bytes length instead of 3 bytes.
I suspect the other structure like 40bits and 56bits have the same issue
Orignal issue was that when sending 0x123456 was ending up as 0x345600 on the zigbee sniffer