Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update confidant chart use standard naming #29

Merged

Conversation

@jrosco
Copy link
Member

jrosco commented Nov 4, 2019

Use standardise naming, making it not only relevant to SAML auth type.

@jrosco jrosco requested review from egeland, matthope and mikelorant as code owners Nov 4, 2019
Copy link
Contributor

egeland left a comment

You'll need to bump the chart version - everything else looks good 👍
https://github.com/fairfaxmedia/charts/blob/master/stable/confidant/Chart.yaml#L5

@jrosco

This comment has been minimized.

Copy link
Member Author

jrosco commented Nov 5, 2019

You'll need to bump the chart version - everything else looks good 👍
https://github.com/fairfaxmedia/charts/blob/master/stable/confidant/Chart.yaml#L5

Bumped chart version. @matthope @egeland

@jrosco jrosco requested review from egeland and matthope Nov 5, 2019
@@ -2,7 +2,7 @@ apiVersion: v1
description: A Helm chart for Confidant (github.com/lyft/confidant)
name: confidant
icon: https://github.com/lyft/confidant/raw/gh-pages/images/safe-1d911346.png
version: 1.3.0
version: 1.3.1

This comment has been minimized.

Copy link
@egeland

egeland Nov 5, 2019

Contributor

Current master is at 1.3.1 already - you need to go to a later number. Given you are adding a new feature, I'd suggest 1.4.0

@egeland
egeland approved these changes Nov 5, 2019
@jrosco jrosco merged commit c880ae5 into fairfaxmedia:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.