Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sp key file password value to chart #31

Merged
merged 1 commit into from Nov 13, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion stable/confidant/Chart.yaml
Expand Up @@ -2,7 +2,7 @@ apiVersion: v1
description: A Helm chart for Confidant (github.com/lyft/confidant)
name: confidant
icon: https://github.com/lyft/confidant/raw/gh-pages/images/safe-1d911346.png
version: 1.4.1
version: 1.4.2
maintainers:
- name: FFX Blue Operations
email: blueops@fairfaxmedia.com.au
2 changes: 1 addition & 1 deletion stable/confidant/README.md
Expand Up @@ -27,7 +27,7 @@ For <http://github.com/lyft/confidant>
| `saml.idpLogoutUrl` | `https://example.onelogin.com/trust/saml2/http-redirect/slo/000000` | .. |
| `saml.spCert` | .. | .. |
| `saml.spKey` | `-----BEGIN PRIVATE KEY-----` | .. |
| `saml.spKeyFilePassword` | `putTheSpKeyPasswordHere` | .. |
| `saml.spKeyFilePassword` | `""` | .. |
| `saml.idpCert` | `-----BEGIN CERTIFICATE-----` | .. |
| `confidant.enableSecurityRoles` | `false` | Can ONLY be used with the fairfaxmedia/confidant:4.4.0-roles docker image. Currently only SAML auth type is supported, future releases may support other auth types |
| `confidant.roleAdmin` | `admin` | Role that's allowed full Admin access |
Expand Down
4 changes: 4 additions & 0 deletions stable/confidant/templates/app-deploy.yaml
Expand Up @@ -134,6 +134,10 @@ spec:
value: {{ .Values.saml.idpEntityId | quote }}
- name: SAML_IDP_LOGOUT_URL
value: {{ .Values.saml.idpLogoutUrl | quote }}
{{ end }}
{{ if .Values.saml.spKeyFilePassword }}
- name: SAML_SP_KEY_FILE_PASSWORD
value: {{ .Values.saml.spKeyFilePassword | quote }}
{{ end }}
ports:
- name: http
Expand Down
2 changes: 1 addition & 1 deletion stable/confidant/values.yaml
Expand Up @@ -33,7 +33,7 @@ saml:
-----BEGIN PRIVATE KEY-----
PUT_YOUR_KEY_HERE
-----END PRIVATE KEY-----
spKeyFilePassword: "putTheSpKeyPasswordHere"
spKeyFilePassword: ""
idpCert: |
-----BEGIN CERTIFICATE-----
PUT_IDENTITY_PROVIDER_CERT_HERE
Expand Down