Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SP Password to k8s secrets #32

Merged

Conversation

@jrosco
Copy link
Member

jrosco commented Mar 10, 2020

SP Password to being logged in plain text, this value should be stored in the k8s secrets so our pipeline etc doesn't log it in plain text.

@jrosco jrosco requested review from egeland, matthope and mikelorant as code owners Mar 10, 2020
@jrosco jrosco requested a review from mikelorant Mar 10, 2020
@jrosco jrosco merged commit e1b0d0d into fairfaxmedia:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.