Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show latest DEPLOYED release when using helm #63

Closed
lucasreed opened this issue Apr 21, 2020 · 1 comment · Fixed by #69
Closed

Only show latest DEPLOYED release when using helm #63

lucasreed opened this issue Apr 21, 2020 · 1 comment · Fixed by #69
Assignees
@lucasreed

Comments

@lucasreed
Copy link
Contributor

There is a bug in helm (2 for sure, unclear when using version 3) that can allow a release to have multiple revisions marked as DEPLOYED. Because of this all of those revisions get listed in pluto output. We should only care about the most recent one.

Bonus: should we also alert the user they are hitting this bug? It is not a feature of helm to have more than one DEPLOYED release at at ime.
@lucasreed lucasreed self-assigned this Apr 27, 2020
@lucasreed
Copy link
Contributor Author

I can fix this while working on #67

@lucasreed lucasreed mentioned this issue Apr 27, 2020
Merged
sudermanjr pushed a commit that referenced this issue Apr 29, 2020
don't show duplicate deployed releases (#63). add release name to the…
5b1de39 
… name output for helm (#67) (#69)

* should not show duplicate deployed releases and adds release name to output for helm

* fixing e2e tests

* another try at fixing e2e testing expected output format

* adding back spacing at end to see if e2e runs successfully

* removing debug log line

* removing extra space from e2e tests

* Update pkg/helm/helm.go

Co-Authored-By: Andrew Suderman <andrew@sudermanjr.com>

* deleting hostpath-provisioner helm chart which is throwing off spacing in e2e

* Trying a new codecov yaml

* break out marshal functionality a bit more

Co-authored-by: Andrew Suderman <andrew@sudermanjr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasreed lucasreed

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@lucasreed