New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stack + Nix CI integration #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review
|
||
## Test for lts16 | ||
test-lts16: | ||
make shell-lts16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: I'm not very familiar with make
, but generally when I see people using recursive make
, they call it recursively like $(MAKE)
: https://www.gnu.org/software/make/manual/html_node/Recursion.html.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I wasn't aware of that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review
After speaking to @cdepillabout , we decided that it's probably not a good idea to use Nix with a CI like that. |
Hi, I'm a bit confused, could you clarify on why it's not a good idea to use nix? Have a good weekend 🙂 |
@jappeace There were two reasons specified by @cdepillabout (correct me if I mis-understood something!):
Also, if you can see the CI builds, the |
This PR tests against latest three stackage resolvers covering different major ghc versions.