Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stack + Nix CI integration #5

Closed
wants to merge 12 commits into from
Closed

Add Stack + Nix CI integration #5

wants to merge 12 commits into from

Conversation

psibi
Copy link
Member

@psibi psibi commented Jun 18, 2021

This PR tests against latest three stackage resolvers covering different major ghc versions.

Copy link

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review


## Test for lts16
test-lts16:
make shell-lts16

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: I'm not very familiar with make, but generally when I see people using recursive make, they call it recursively like $(MAKE): https://www.gnu.org/software/make/manual/html_node/Recursion.html.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I wasn't aware of that!

Copy link

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

@psibi
Copy link
Member Author

psibi commented Jun 19, 2021

After speaking to @cdepillabout , we decided that it's probably not a good idea to use Nix with a CI like that.

@psibi psibi closed this Jun 19, 2021
@jappeace
Copy link
Collaborator

Hi, I'm a bit confused, could you clarify on why it's not a good idea to use nix?
Can't we test against different versions of ghc with nix? I'm reasonably sure I've done that before (here for example)

Have a good weekend 🙂

@psibi
Copy link
Member Author

psibi commented Jun 19, 2021

@jappeace There were two reasons specified by @cdepillabout (correct me if I mis-understood something!):

  • If the idea is to test against last three stackage lts resolvers, it's just much easier to test it using the usual approach of using stack. (similar to how it's done for the package fakedata)
  • This package doesn't have any native dependency etc to actually make it useful to use Nix.

Also, if you can see the CI builds, the lts14 builds fail because of some weird issue going on with the way Nix packages ghc865Binary. So for this one case - we have to either go to an older nix package set to make it work or actually fix the nix issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants