Ruby 1 9 3 support #114

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

lukaso commented Dec 21, 2011

I've got 1.9.3 support working for Pathname, in a sort of monkeypatch way, but now all the tests pass in 1.9.3.

I do think there's a ruby bug with the inability to do the unset_const of a built in class for C based implementations, but that's for another venue probably.

I've run all the tests on 1.9.3 and 1.9.2.

Thanks. Hope it's helpful!

-Lukas

lukaso added some commits Dec 20, 2011

Add advise function to File which is in ruby 1.9.3. As it is only a h…
…int to the

os in some cases, the function does nothing.
Bumped version.
Moved pathname.rb from ruby 1.9.2 into project in order to continue compatibility to 1.9.3 where
the functionality has been moved into c. In the c version of the file, the unset_const trick
doesn't work because the constant rb_cFile in the c file is never modified. I think this is
actually a bug in how ruby MRI operates, but the fix is a little bit complicated.

@jfirebaugh jfirebaugh referenced this pull request Apr 17, 2012

Merged

Omnibus pull request #124

Collaborator

jfirebaugh commented May 1, 2012

Thanks! Committed in 332735b and dc0d08d.

Note that it's generally good practice to avoid changing the version number in a pull request, as maintainers will want to handle that independently.

@jfirebaugh jfirebaugh closed this May 1, 2012

Contributor

lukaso commented May 1, 2012

Sorry about the version. Thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment