New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint away 2 TODOs from the .rubocop_todo.yml #357

Merged
merged 4 commits into from Nov 10, 2016

Conversation

Projects
None yet
2 participants
@olleolleolle
Contributor

olleolleolle commented Nov 10, 2016

This PR fixes lint issues and regenerates the TODO file.


Method to locate lints one at a time:

  • choose a "cop" from the .rubocop_todo.yml file
  • remove the line which includes the .rubocop_todo.yml
  • rubocop --only Lint/IneffectiveAccessModifier
  • fix issues and test fixes with the --only invocation
  • rubocop --auto-gen-config to regenerate the .rubocop_todo.yml file
  • git checkout .rubocop.yml to add back include line
  • commit this change with the name of the "cop" used

@olleolleolle olleolleolle changed the title from Lint away 1 TODO from the .rubocop_todo.yml to Lint away 2 TODOs from the .rubocop_todo.yml Nov 10, 2016

Show outdated Hide outdated lib/fakefs/dir.rb
else
files = matches_for_pattern.call pattern
end
files = if pattern.is_a?(Array)

This comment has been minimized.

@grosser

grosser Nov 10, 2016

Collaborator

prefer this to stay with 2-space indent and don't waste whitespace or having to adjust whitespace when var name changes

files = 
  if dfsdfsfd
@grosser

grosser Nov 10, 2016

Collaborator

prefer this to stay with 2-space indent and don't waste whitespace or having to adjust whitespace when var name changes

files = 
  if dfsdfsfd

This comment has been minimized.

@olleolleolle

olleolleolle Nov 10, 2016

Contributor

Well, then I'll change this PR so that we can do that and not have Rubocop complain.

@olleolleolle

olleolleolle Nov 10, 2016

Contributor

Well, then I'll change this PR so that we can do that and not have Rubocop complain.

This comment has been minimized.

@olleolleolle

olleolleolle Nov 10, 2016

Contributor

Your answer was so terse I missed the whole point. Now taken, and implemented.

@olleolleolle

olleolleolle Nov 10, 2016

Contributor

Your answer was so terse I missed the whole point. Now taken, and implemented.

Show outdated Hide outdated lib/fakefs/pathname.rb
else
result << self.class.new(e)
end
result << if with_directory

This comment has been minimized.

@grosser

grosser Nov 10, 2016

Collaborator

1 more :D

@grosser

grosser Nov 10, 2016

Collaborator

1 more :D

This comment has been minimized.

@olleolleolle

olleolleolle Nov 10, 2016

Contributor

Ah, I'm a slob. I'll fix!

@olleolleolle

olleolleolle Nov 10, 2016

Contributor

Ah, I'm a slob. I'll fix!

@grosser

This comment has been minimized.

Show comment
Hide comment
@grosser

grosser Nov 10, 2016

Collaborator

❤️ good step in the right direction :)
I'll wait for green

Collaborator

grosser commented Nov 10, 2016

❤️ good step in the right direction :)
I'll wait for green

@grosser grosser merged commit cb874ff into fakefs:master Nov 10, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@olleolleolle olleolleolle deleted the olleolleolle:fix/auto-regen-rubocop branch Nov 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment