fix: fake is unable to return empty strings #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
force-pushed
the
fix/fake-empty-result
branch
from
f5ab86a
to
95bab2c
Compare
Codecov Report
@@ Coverage Diff @@
## main #347 +/- ##
==========================================
- Coverage 99.33% 99.33% -0.01%
==========================================
Files 1923 1923
Lines 176856 176860 +4
Branches 915 915
==========================================
+ Hits 175688 175690 +2
- Misses 1112 1114 +2
Partials 56 56
|
ST-DDT
force-pushed
the
fix/fake-empty-result
branch
from
95bab2c
to
237a50c
Compare
Shinigami92
reviewed
Feb 7, 2022
Shinigami92
previously approved these changes
Feb 12, 2022
import-brain
previously approved these changes
Feb 17, 2022
ST-DDT
force-pushed
the
fix/fake-empty-result
branch
from
bb8163a
to
ec84e18
Compare
Shinigami92
previously approved these changes
Mar 10, 2022
Shinigami92
added
p: 1-normal
ST-DDT
force-pushed
the
fix/fake-empty-result
branch
from
ec84e18
to
3243697
Compare
ST-DDT
force-pushed
the
fix/fake-empty-result
branch
from
3243697
to
015a24e
Compare
Shinigami92
previously approved these changes
Mar 21, 2022
ST-DDT
force-pushed
the
fix/fake-empty-result
branch
from
015a24e
to
b99fb8d
Compare
Shinigami92
previously approved these changes
Mar 22, 2022
ST-DDT
force-pushed
the
fix/fake-empty-result
branch
from
0da3df0
to
e09d083
Compare
Shinigami92
approved these changes
Mar 24, 2022
prisis
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fake should behave exactly like the methods being called directly.
That is if the called method returns an empty string, then fake should do the same (and not fail like it does right now).