Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test random.alphaNumeric #517

Merged
merged 6 commits into from
Feb 19, 2022
Merged

fix: test random.alphaNumeric #517

merged 6 commits into from
Feb 19, 2022

Conversation

xDivisionByZerox
Copy link
Member

Created in relation to #513.

  • split the failing test case into 2 explicit once
  • fixed typo in surrounding test case
  • added todo test case

test/random.spec.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #517 (39536e8) into main (9138ea0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #517   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1919     1919           
  Lines      176294   176294           
  Branches      904      904           
=======================================
  Hits       175137   175137           
  Misses       1101     1101           
  Partials       56       56           

test/random.spec.ts Show resolved Hide resolved
test/random.spec.ts Outdated Show resolved Hide resolved
test/random.spec.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested a review from a team February 19, 2022 21:40
@ST-DDT ST-DDT merged commit 41ec6f0 into faker-js:main Feb 19, 2022
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
Co-authored-by: Leyla Jähnig <leyla.jaehnig@outlook.de>
@xDivisionByZerox xDivisionByZerox deleted the fix/test-random-alpha-numeric branch April 15, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken random.alphaNumeric() test
4 participants