Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update mcr.microsoft.com/devcontainers/typescript-node docker tag to v22 #2917

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 20, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
mcr.microsoft.com/devcontainers/typescript-node image major 20 -> 22

Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner May 20, 2024 07:00
@renovate renovate bot added c: dependencies Pull requests that adds/updates a dependency p: 1-normal Nothing urgent labels May 20, 2024
@renovate renovate bot added this to the vAnytime milestone May 20, 2024
Copy link

netlify bot commented May 20, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit e100ca6
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6654476a452d0a0008ca0fc2
😎 Deploy Preview https://deploy-preview-2917.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (29c5a18) to head (e100ca6).

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #2917    +/-   ##
========================================
  Coverage   99.95%   99.96%            
========================================
  Files        2977     2977            
  Lines      215421   215421            
  Branches      951      600   -351     
========================================
+ Hits       215334   215335     +1     
+ Misses         87       86     -1     

see 1 file with indirect coverage changes

Copy link
Contributor

@matthewmayer matthewmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt we add node 22 to CI before we make it the default?

@ST-DDT
Copy link
Member

ST-DDT commented May 20, 2024

shouldnt we add node 22 to CI before we make it the default?

Yeah, makes sense.

Although on second thought I'm no longer sure we should switch to latest node yet.

@matthewmayer
Copy link
Contributor

When does this file actually get used?

@ST-DDT
Copy link
Member

ST-DDT commented May 21, 2024

It can be used to checkout untrusted code.
VSCode has a button/menu entry to checkout PRs in a devcontainer.

@renovate renovate bot force-pushed the renovate/mcr.microsoft.com-devcontainers-typescript-node-22.x branch from 82dc539 to 99b0f49 Compare May 21, 2024 14:21
@matthewmayer matthewmayer added the s: needs decision Needs team/maintainer decision label May 21, 2024
@renovate renovate bot force-pushed the renovate/mcr.microsoft.com-devcontainers-typescript-node-22.x branch 2 times, most recently from 2bb0c29 to 0a00cf3 Compare May 23, 2024 11:25
@ST-DDT ST-DDT added s: on hold Blocked by something or frozen to avoid conflicts s: needs decision Needs team/maintainer decision and removed s: needs decision Needs team/maintainer decision labels May 23, 2024
@ST-DDT
Copy link
Member

ST-DDT commented May 23, 2024

Blocked by: #2918

@ST-DDT ST-DDT removed the s: needs decision Needs team/maintainer decision label May 23, 2024
@xDivisionByZerox xDivisionByZerox removed the s: on hold Blocked by something or frozen to avoid conflicts label May 27, 2024
@renovate renovate bot force-pushed the renovate/mcr.microsoft.com-devcontainers-typescript-node-22.x branch from 3193a09 to e100ca6 Compare May 27, 2024 08:42
@xDivisionByZerox xDivisionByZerox enabled auto-merge (squash) May 27, 2024 08:48
@xDivisionByZerox xDivisionByZerox merged commit 4250869 into next May 27, 2024
25 checks passed
@xDivisionByZerox xDivisionByZerox deleted the renovate/mcr.microsoft.com-devcontainers-typescript-node-22.x branch May 27, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: dependencies Pull requests that adds/updates a dependency p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants