Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Emojis 馃檪馃槑馃摎馃泴馃挵 #49

Draft
wants to merge 1 commit into
base: master
from

Conversation

@akabiru
Copy link
Member

akabiru commented Sep 1, 2019

Description

Hey, I thought it'd be cool if we had a set of emojis for every Faker constant. I think it makes the CLI more fun and cooler. 馃槃 Here's an initial POC. WDYT? @bpleslie @vbrazo

Screenshot 2019-09-01 at 22 32 49

Considerations

  • Windows support - not sure if emojis are natively supported. TODO: 馃摎
  • Make the feature optional; allow users to toggle it off
@bpleslie

This comment has been minimized.

Copy link
Member

bpleslie commented Sep 2, 2019

I think this is cool, but I agree there should be a way to disable the emoji output.

'Faker::Currency' => ['馃挵', '馃', '馃捀', '馃挼'],
'Faker::Date' => ['馃搮'],
'Faker::DcComics' => ['馃', '馃Ω鈥', '馃Ω鈥'],
'Faker::Demographic' => ['馃泴', '馃檸鈥', '馃檷鈥嶁檪锔'],

This comment has been minimized.

Copy link
@vbrazo

vbrazo Sep 2, 2019

Member

I think we do this in a different way in Faker. Check this and this out and let me know your thoughts.

This comment has been minimized.

Copy link
@akabiru

akabiru Sep 4, 2019

Author Member

Aaah, interesting approach! I'll have a look. 馃檪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.