From 6a75a789f4a8827cb7723f8394f82c607cf58af5 Mon Sep 17 00:00:00 2001 From: Kamil Bielawski Date: Wed, 27 Feb 2019 20:35:01 +0100 Subject: [PATCH] Extend list of cryptocurrencies (#1554) * Extend list of cryptocurrencies * Adjust coin name regex --- doc/default/crypto_coin.md | 4 +-- lib/locales/en/crypto_coin.yml | 28 +++++++++++++++----- test/faker/default/test_faker_crypto_coin.rb | 2 +- 3 files changed, 25 insertions(+), 9 deletions(-) diff --git a/doc/default/crypto_coin.md b/doc/default/crypto_coin.md index a99304ffe0..c89d79f56f 100644 --- a/doc/default/crypto_coin.md +++ b/doc/default/crypto_coin.md @@ -5,9 +5,9 @@ Faker::CryptoCoin.coin_name #=> "Bitcoin" Faker::CryptoCoin.acronym #=> "BTC" -Faker::CryptoCoin.url_logo #=> "https://i.imgur.com/EFz61Ei.png" +Faker::CryptoCoin.url_logo #=> "https://i.imgur.com/EFz61Ei.png" Faker::CryptoCoin.coin_array #=> ["Dash", "DASH", "https://i.imgur.com/2uX91cb.png"] -Faker::CryptoCoin.coin_hash {:name=>"Ethereum", :acronym=>"ETH", :url_logo=>"https://i.imgur.com/uOPFCXj.png"} +Faker::CryptoCoin.coin_hash {:name=>"Ethereum", :acronym=>"ETH", :url_logo=>"https://i.imgur.com/uOPFCXj.png"} ``` diff --git a/lib/locales/en/crypto_coin.yml b/lib/locales/en/crypto_coin.yml index a3b3d60f1a..1280a1a9d6 100644 --- a/lib/locales/en/crypto_coin.yml +++ b/lib/locales/en/crypto_coin.yml @@ -1,9 +1,25 @@ en: faker: crypto_coin: - coin: - - "Bitcoin, BTC, https://i.imgur.com/psBNOBq.png" - - "Litecoin, LTC, https://i.imgur.com/EFz61Ei.png" - - "Dash, DASH, https://i.imgur.com/2uX91cb.png" - - "Ethereum, ETH, https://i.imgur.com/uOPFCXj.png" - - "Ripple, XRP, https://i.imgur.com/GjAPSsL.png" + coin: + - "Bitcoin, BTC, https://i.imgur.com/psBNOBq.png" + - "Bitcoin Cash, BCC, https://i.imgur.com/ViTjr9u.png" + - "Bitcoin Gold, BTG, https://i.imgur.com/l9cVE7c.png" + - "Bitcoin SV, BSV, https://i.imgur.com/DkixrAc.png" + - "Binance Coin, BNB, https://i.imgur.com/2HJr7OR.png" + - "Cardano, ADA, https://i.imgur.com/8qGU4zg.png" + - "Dash, DASH, https://i.imgur.com/2uX91cb.png" + - "Decred, DCR, https://i.imgur.com/nURXAC2.png" + - "EOS.IO, EOS, https://i.imgur.com/Cr2w77s.png" + - "Ethereum, ETH, https://i.imgur.com/uOPFCXj.png" + - "Ethereum Classic, ETC, https://i.imgur.com/8wBtmQA.png" + - "IOTA, IOT, https://i.imgur.com/DGFCOVt.png" + - "Litecoin, LTC, https://i.imgur.com/EFz61Ei.png" + - "Monero, XMR, https://i.imgur.com/pnupcJM.png" + - "NEM, XEM, https://i.imgur.com/SJ8NteF.png" + - "NEO, NEO, https://i.imgur.com/BmtVrJi.png" + - "Ripple, XRP, https://i.imgur.com/GjAPSsL.png" + - "Stellar, XLM, https://i.imgur.com/COLIHUE.png" + - "Tether, USDT, https://i.imgur.com/xk6pQZy.png" + - "TRON, TRX, https://i.imgur.com/grG05ZK.png" + - "Zcash, ZEC, https://i.imgur.com/mX3r4j9.png" diff --git a/test/faker/default/test_faker_crypto_coin.rb b/test/faker/default/test_faker_crypto_coin.rb index da809794f5..b2e84db7df 100644 --- a/test/faker/default/test_faker_crypto_coin.rb +++ b/test/faker/default/test_faker_crypto_coin.rb @@ -7,7 +7,7 @@ class TestFakerCryptoCoin < Test::Unit::TestCase ACRONYM = 1 URL_LOGO = 2 - REGEX_COIN_NAME = /\w+{4,}/ + REGEX_COIN_NAME = /[a-zA-Z \.]{3,}/ REGEX_ACRONYM = /\w+{3,}/ REGEX_URL_LOGO = /^https:\/\/i.imgur.com\/.......\./