Make compatible with new React version 16 and add character count for existing characters #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… existing text This package wasn't unusable with React 16 removed deprecation of React.PropTypes https://github.com/facebook/react/blob/master/CHANGELOG.md#removed-deprecations
Make compatible with new React version 16 and add character count for…
atuttle
reviewed
Apr 23, 2019
| renderCount() { | ||
| const { countLimit } = this.props; | ||
| const className = `textarea__count${this.textarea && countLimit && this.textarea.value.length > countLimit ? ' textarea__count--error' : ''}`; | ||
| const className = `textarea__count${this.textarea && countLimit && this.textarea.value.length >= countLimit ? ' textarea__count--error' : ''}`; |
There was a problem hiding this comment.
I don't think this change belongs in this pull request.
If anything, it should be extracted out to a separate request. (And I would debate whether it should be accepted, because if the limit is 100 and there are 100 characters, that should be valid, shouldn't it?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.