feat(storage): add support for GCS as storage driver #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishorviswanathan
changed the title
Collaborator
|
Looks good but we still need to find a way to add tests for this. Are there any gcs emulators for local development? |
Contributor
Author
|
@LouisHaftmann I found this, will give it a try. |
Contributor
Author
|
@LouisHaftmann I have added the test and that helped me to identify a bug. Thanks for the suggestion. |
LouisHaftmann
requested changes
Sep 5, 2024
Collaborator
LouisHaftmann
left a comment
LouisHaftmann
left a comment
There was a problem hiding this comment.
Just one tiny nitpick: Could we rename STORAGE_GCS_SERVICEACCOUNT_KEY to STORAGE_GCS_SERVICE_ACCOUNT_KEY for the sake of consistency?
Contributor
Author
|
Done. Renamed it. |
LouisHaftmann
approved these changes
Sep 5, 2024
Collaborator
|
Thank you! ❤️ |
Collaborator
|
Will be available in the next release. You can check it out now with the dev image |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(storage): add support for GCS as storage driver
This PR aims to add support for Google Cloud Storage (GCS) as a storage driver.