Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix for passwords/usernames containing # #8

Closed
wants to merge 1 commit into from

2 participants

@mika-fischer

Previously, passwords containing # would be cut short, because the #
and everything afterwards was treated as a comment.

This removes support for comments that don't start at the beginning of a
line but fixes passwords and usernames containing #

@mika-fischer mika-fischer Fix for passwords/usernames containing #
Previously, passwords containing # would be cut short, because the #
and everything afterwards was treated as a comment.

This removes support for comments that don't start at the beginning of a
line but fixes passwords and usernames containing #
6ee1f1e
@mika-fischer

Maybe this is too intrusive (might break existing configs). But the only other way I can see is to support proper quoting.
And I don't really want to open that can of worms...

@falconindy
Owner

Yeah this is probably the right thing to do here. I don't want to get into the business of dealing with quoting, and anything heuristic based is just going to introduce edge cases. I'm not in a position to merge this right now, but I'll get to it this weekend.

@falconindy
Owner

Thanks, merged this as is, but cleaned up the commit message.

@falconindy falconindy closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 29, 2012
  1. @mika-fischer

    Fix for passwords/usernames containing #

    mika-fischer authored
    Previously, passwords containing # would be cut short, because the #
    and everything afterwards was treated as a comment.
    
    This removes support for comments that don't start at the beginning of a
    line but fixes passwords and usernames containing #
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 6 deletions.
  1. +2 −2 README.pod
  2. +0 −4 burp.c
View
4 README.pod
@@ -86,8 +86,8 @@ Persist<br/>
=end html
These should all be self explanatory. Comments, if desired, can be specified
-with a #. Command line options will always take precedence over options specified
-in the config file.
+by starting a line with a #. Command line options will always take precedence
+over options specified in the config file.
=head1 AUTHOR
View
4 burp.c
@@ -247,10 +247,6 @@ static int read_config_file(void) {
continue;
}
- if ((ptr = strchr(line, '#'))) {
- *ptr = '\0';
- }
-
key = ptr = line;
strsep(&ptr, "=");
strtrim(key);
Something went wrong with that request. Please try again.