The default cfg.color value should be 0? #14

Closed
lolilolicon opened this Issue Apr 13, 2011 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

lolilolicon commented Apr 13, 2011

cfg.color is initialized as UNSET (-1). Using the --color flag always sets cfg.color to 0 or 1, while if no --color is passed cfg.color stays -1.
This to me doesn't make much sense. For example, cower -s <term> does not colorize results, AND no <!> flag is added to the results to indicate OOD status. Seems surprising to me.
IMO, the cfg.color should be set to 0 when no --color flag is passed.

Owner

falconindy commented Apr 13, 2011

You would be correct! I'll fix this brown baggery.

@falconindy falconindy added a commit that referenced this issue Apr 13, 2011

@falconindy falconindy fallback from sentinel value on cfg.color
fixes GH #14

Thanks-To: lolilolicon
50bfa6a
Owner

falconindy commented Apr 13, 2011

Fixed in 50bfa6a

falconindy closed this Apr 13, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment