Remove some macros #54

Merged
merged 6 commits into from Apr 30, 2013

Conversation

Projects
None yet
2 participants
@vodik
Contributor

vodik commented Apr 3, 2013

  • Replace STREQ with a streq function.
  • Replace STR_STARTS_WITH with a startswith function.
  • Remove FREE, CALLOC, and MALLOC macros.
  • Statically initialize colstr so its not on the stack
  • Mark all global variables as static
@falconindy

This comment has been minimized.

Show comment Hide comment
@falconindy

falconindy Apr 9, 2013

Looks like you missed 2 places where this could be used -- in keycmp and aurpkg_cmp

Looks like you missed 2 places where this could be used -- in keycmp and aurpkg_cmp

This comment has been minimized.

Show comment Hide comment
@vodik

vodik Apr 10, 2013

Owner

No I can't, because those functions are used by searching methods: keycmp in bseach and aurpkg_cmp in alpm_list_msort.

Owner

vodik replied Apr 10, 2013

No I can't, because those functions are used by searching methods: keycmp in bseach and aurpkg_cmp in alpm_list_msort.

@falconindy falconindy merged commit 88dc44d into falconindy:master Apr 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment