Add command_not_found_handler for fish shell #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This won't install the hook the doc dir, making it not so useful. Could you amend your change to wire this up to the makefile? It should be a one liner... |
CIAvash
force-pushed
the
command_not_found_for_fish
branch
from
a5243c8
to
445be95
Compare
|
Changed Makefile and README. Is this correct? |
|
Looks correct at a glance, but the computer can tell you a lot more. Does the built manpage look correct (POD errors show up at the bottom of the compiled page)? Does 'make distcheck' pass? |
|
Yes, everything looks good. |
falconindy
added a commit
that referenced
this pull request
Sep 14, 2014
Add command_not_found_handler for fish shell
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to keep it similar to the other scripts. But I didn't return anything because fish outputs
fish: Unknown command 'command-name'and returns127in the end.