Skip to content

Don't connect to pulseaudio with PA_CONTEXT_NOFAIL #16

Merged
merged 1 commit into from Apr 8, 2013

3 participants

@vodik
vodik commented Apr 8, 2013

NOFAIL means we don't fail if the daemon is not available when pa_context_connect() is called and instead enter PA_CONTEXT_CONNECTING state and wait for the daemon to appear.

So currently if pulseaudio isn't running or available, ponymix will just block and wait. Since a lot of people use ponymix bound to their volume keys, this could potentially mean spawning 100s of processes before actually catching on that things aren't working.

PA_CONTEXT_NOFLAGS was introduced in 0.9.19. Its really just 0.

Signed-off-by: Simon Gomizelj simongmzlj@gmail.com

@vodik vodik Don't connect with PA_CONTEXT_NOFAIL
NOFAIL means we don't fail if the daemon is not available when
pa_context_connect() is called and instead enter PA_CONTEXT_CONNECTING
state and wait for the daemon to appear.

So currently if pulseaudio isn't running or available, ponymix will just
block and wait. Since a lot of people use ponymix bound to their volume
keys, this could potentially mean spawning 100s of processes before
actually catching on that things aren't working.

PA_CONTEXT_NOFLAGS was introduced in 0.9.19. Its really just 0.

Signed-off-by: Simon Gomizelj <simongmzlj@gmail.com>
ebf3e56
@numerical

Some of us are stupid and get thousands of processes

@falconindy
Owner

Cool, seems like we already handle the error and do the right thing when pulse isn't up and running.

@falconindy falconindy merged commit 6922219 into falconindy:master Apr 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.