Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Clamp volumes between a more intelligent range #17

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

vodik commented Apr 10, 2013

This handles volume increment/decrement better when volume is >100%.

If volume is above 100%, incrementing or decrementing the volume will automatically drop it back down to 100%. It be better if decrementing worked as expected and we just didn't increment the volume further.

@vodik vodik Clamp volumes between a more intelligent range
This handles volume increment/decrement better when volume is >100%.

If volume is above 100%, incrementing or decrementing the volume will
automatically drop it back down to 100%. It be better if decrementing
worked as expected and we just didn't increment the volume further.

Signed-off-by: Simon Gomizelj <simongmzlj@gmail.com>
898271e

I don't get it. Doesn't this effectively prevent you from increasing the volume if the max is the current (pre-adjustment)?

Owner

falconindy commented Apr 10, 2013

Yeah. This is totally broke.

$ ./ponymix increase 5
45
$ ./ponymix increase 5
45
$ ./ponymix increase 5
45
Owner

falconindy commented Apr 10, 2013

7d987d2 fixes this.

@falconindy falconindy closed this Apr 10, 2013

Contributor

vodik commented Apr 10, 2013

Derp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment