Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Clamp volumes between a more intelligent range #17

Closed
wants to merge 1 commit into from

2 participants

@vodik

This handles volume increment/decrement better when volume is >100%.

If volume is above 100%, incrementing or decrementing the volume will automatically drop it back down to 100%. It be better if decrementing worked as expected and we just didn't increment the volume further.

@vodik vodik Clamp volumes between a more intelligent range
This handles volume increment/decrement better when volume is >100%.

If volume is above 100%, incrementing or decrementing the volume will
automatically drop it back down to 100%. It be better if decrementing
worked as expected and we just didn't increment the volume further.

Signed-off-by: Simon Gomizelj <simongmzlj@gmail.com>
898271e
@falconindy
Owner

I don't get it. Doesn't this effectively prevent you from increasing the volume if the max is the current (pre-adjustment)?

@falconindy
Owner

Yeah. This is totally broke.

$ ./ponymix increase 5
45
$ ./ponymix increase 5
45
$ ./ponymix increase 5
45
@falconindy
Owner

7d987d2 fixes this.

@falconindy falconindy closed this
@vodik

Derp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 10, 2013
  1. @vodik

    Clamp volumes between a more intelligent range

    vodik authored
    This handles volume increment/decrement better when volume is >100%.
    
    If volume is above 100%, incrementing or decrementing the volume will
    automatically drop it back down to 100%. It be better if decrementing
    worked as expected and we just didn't increment the volume further.
    
    Signed-off-by: Simon Gomizelj <simongmzlj@gmail.com>
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  ponymix.cc
View
2  ponymix.cc
@@ -325,7 +325,7 @@ static int adj_volume(PulseClient& ponymix,
errx(1, "error: failed to convert string to integer: %s", argv[0]);
}
- ponymix.SetVolumeRange(0, 100);
+ ponymix.SetVolumeRange(0, device->Volume());
return !(ponymix.*adjust)(*device, delta);
}
Something went wrong with that request. Please try again.