New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure long description is Unicode string in setup #201

Merged
merged 1 commit into from Nov 18, 2013

Conversation

Projects
None yet
2 participants
@jaypipes
Contributor

jaypipes commented Nov 2, 2013

Python 3.3 is not able to properly install Falcon
due to UTF-8 characters in the README.rst file. The
characters are fine, we just need to be sure to decode
the open('README.rst', 'rb').read() bytestring as a
unicode string.

An example of the setup failure can be seen here:

UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 586: ordinal not in range(128)

http://logs.openstack.org/40/55040/2/check/gate-solum-python33/02f9aca/console.html

Ensure long description is Unicode string in setup
Python 3.3 is not able to properly install Falcon
due to UTF-8 characters in the README.rst file. The
characters are fine, we just need to be sure to decode
the open('README.rst', 'rb').read() bytestring as a
unicode string.

An example of the setup failure can be seen here:

UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 586: ordinal not in range(128)

http://logs.openstack.org/40/55040/2/check/gate-solum-python33/02f9aca/console.html
@jaypipes

This comment has been minimized.

Show comment
Hide comment
@jaypipes

jaypipes Nov 2, 2013

Contributor

OK, that did it. :)

Contributor

jaypipes commented Nov 2, 2013

OK, that did it. :)

@kgriffs

This comment has been minimized.

Show comment
Hide comment
@kgriffs

kgriffs Nov 18, 2013

Contributor

Nice catch. Thanks!

Contributor

kgriffs commented Nov 18, 2013

Nice catch. Thanks!

kgriffs added a commit that referenced this pull request Nov 18, 2013

Merge pull request #201 from jaypipes/utf8setup
Ensure long description is Unicode string in setup

@kgriffs kgriffs merged commit f2e9398 into falconry:master Nov 18, 2013

1 check passed

default The Travis CI build passed
Details

@jaypipes jaypipes deleted the jaypipes:utf8setup branch Feb 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment