Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): pin pytest + ASGI tutorial fixes #2233

Merged
merged 1 commit into from
May 7, 2024

Conversation

vytas7
Copy link
Member

@vytas7 vytas7 commented May 7, 2024

It seems that something breaks when using testtools.TestCase under pytest 8.2.x along the lines of pytest-dev/pytest#12263. This PR temporarily pins pytest until the issue is resolved upstream, or we decide on how we want to move forward with this. An alternative is to drop active support for testtools altogether: #2156.

Also patched is some typing import issue in ASGI tutorial tests. The issue seems to also stem from third party packages (fakeredis) under Python 3.10 that we had hardwired in the tox env by mistake. I'll file a followup issue, because this also means that our tutorial is not fully usable on 3.10 or older.

@vytas7 vytas7 requested review from CaselIT, nZac and kgriffs May 7, 2024 07:49
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e619c39) to head (ddce076).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2233   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         6931      6931           
  Branches      1258      1258           
=========================================
  Hits          6931      6931           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also be ok in dropping testtools, but for now this is fine

@vytas7 vytas7 merged commit c4a5f32 into falconry:master May 7, 2024
37 checks passed
@vytas7 vytas7 deleted the wrestle-ci-202405 branch August 20, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants