New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(pep8): Add flake8-import-order plugin with import order changes (#798) #808

Merged
merged 1 commit into from Jun 2, 2016

Conversation

Projects
None yet
4 participants
@jessehudl

jessehudl commented Jun 2, 2016

PyCon 2016 sprint! Addresses #798.

Adds flake8-import-order plugin to the tox configuration file, along with all the reordering of existing imports in order to pass. Using the Google import order style as requested by @kgriffs.

Also adds --application-import-names=falcon as specified in #798.

@codecov-io

This comment has been minimized.

codecov-io commented Jun 2, 2016

Current coverage is 100%

Merging #808 into master will not change coverage

@@             master       #808   diff @@
==========================================
  Files            29         29          
  Lines          1777       1774     -3   
  Methods           0          0          
  Messages          0          0          
  Branches        299        299          
==========================================
- Hits           1777       1774     -3   
  Misses            0          0          
  Partials          0          0          

Powered by Codecov. Last updated by 643f9e4...fa049e4

@fxfitz

This comment has been minimized.

Contributor

fxfitz commented Jun 2, 2016

LGTM

@kgriffs

This comment has been minimized.

Contributor

kgriffs commented Jun 2, 2016

LGTM, thanks!

@kgriffs kgriffs merged commit 10d1b7e into falconry:master Jun 2, 2016

2 checks passed

codecov/project 100% (target 100%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jessehudl jessehudl deleted the jessehudl:add-flake8-import-order branch Jun 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment