New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker socket and /dev should not be read-only in daemonset #295

Closed
wants to merge 1 commit into
base: dev
from

Conversation

Projects
None yet
2 participants
@agilgur5

agilgur5 commented Nov 3, 2017

  • these aren't read-only in any other examples
docker socket and /dev should not be read-only in daemonset
- these aren't read-only in any other examples
@mstemm

This comment has been minimized.

Contributor

mstemm commented Feb 20, 2018

Good point! We made some changes since this PR was proposed to split the falco daemonset into rbac and non-rbac methods, so I'll make the change in a separate PR #325.

@agilgur5

This comment has been minimized.

agilgur5 commented Feb 20, 2018

@mstemm it is courtesy to ensure contributors are credited with their changes. I'm personally quite copious in projects I maintain to ensure contributors receive their due credit, even if I have made changes to their changes (I would be committer and they author), and particularly so when there are conflicts that occurred months after their PR. Just my 2 cents...

@mstemm

This comment has been minimized.

Contributor

mstemm commented Feb 21, 2018

Sorry, you're right--I should have waited for an updated PR that had the same changes applied to the updated files, which got moved to new subdirectories. I only went ahead with making the same changes on the updated files myself, as it was a fairly small change. I'll make sure I stay with the original PRs in the future.

@agilgur5

This comment has been minimized.

agilgur5 commented Feb 21, 2018

Ok, thanks for the note! In the past, I've also just taken commits and amended or rebased them myself, so closing the PR, but leaving the contributor as the author of the commit that gets put into master (examples are probably better than words: agilgur5/react-signature-canvas#14 (comment)). It's something I've seen often in projects that follow a rebase style (e.g. Django)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment