New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use https://kubernetes.default instead of just https://kubernetes #296

Closed
wants to merge 1 commit into
base: dev
from

Conversation

Projects
None yet
2 participants
@agilgur5

agilgur5 commented Nov 3, 2017

  • otherwise it doesn't work if it's in a different namespace
use https://kubernetes.default instead of just https://kubernetes
- otherwise it doesn't work if it's in a different namespace

mstemm added a commit that referenced this pull request Feb 20, 2018

Use kubernetes.default to reach k8s api server
Originally raised in #296, but since then we documented rbac and
without-rbac methods, so mirroring the change here.
@mstemm

This comment has been minimized.

Contributor

mstemm commented Feb 20, 2018

Since this PR was proposed, we made some other changes to document rbac and non-rbac methods for deploying falco, so this PR has conflicts. I carried the change over in a new PR #325, so I'll close this one.

@mstemm mstemm closed this Feb 20, 2018

mstemm added a commit that referenced this pull request Feb 20, 2018

Improvements to falco daemonset configuration (#325)
* Use kubernetes.default to reach k8s api server

Originally raised in #296, but since then we documented rbac and
without-rbac methods, so mirroring the change here.

* Mount docker socket/dev read-write

This matches the direct docker run commands, which also mount those
resources read-write.
@agilgur5

This comment has been minimized.

agilgur5 commented Feb 20, 2018

Same note as #295 (comment)

@mstemm

This comment has been minimized.

Contributor

mstemm commented Feb 21, 2018

Indeed, I'll make sure I stay with the original PRs in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment