New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use better way to skip falco events #356

Merged
merged 2 commits into from Apr 24, 2018

Conversation

Projects
None yet
1 participant
@mstemm
Contributor

mstemm commented Apr 20, 2018

Use the new method falco_consider() to determine which events to
skip. This centralizes the logic in a single function.

This depends on draios/sysdig#1105.

@mstemm mstemm added the in progress label Apr 20, 2018

mstemm added some commits Apr 20, 2018

Use better way to skip falco events
Use the new method falco_consider() to determine which events to
skip. This centralizes the logic in a single function. All events will
still be considered if falco was run with -A.

This depends on draios/sysdig#1105.
Add ability to specify -A flag in tests
test attribute all_events corresponds to the -A flag. Add for some tests
that would normally refer to skipped events.

@mstemm mstemm merged commit 9d3392e into dev Apr 24, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
sign-off-checker The commit doesn't require sysdig sign-off CLA because it belongs to mstemm part of draios/falco collaborators
Details

@mstemm mstemm deleted the more-ef-drop-falco branch Apr 24, 2018

@mstemm mstemm removed the in progress label Apr 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment