Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k8s.ns.name to output when -pk flag passed #472

Merged
merged 1 commit into from Nov 28, 2018
Merged

Conversation

mfdii
Copy link
Member

@mfdii mfdii commented Nov 21, 2018

Fixing #413. The request to also include cluster name isn't possible right now as that's not a field we are collecting from the Kubernetes API Server, and requires more code changes than this fix.

@mfdii mfdii requested a review from mstemm November 21, 2018 04:11
@mfdii mfdii changed the title Add k8s.ns.name to output when -k flag passed Add k8s.ns.name to output when -pk flag passed Nov 21, 2018
Copy link
Contributor

@mstemm mstemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@mstemm mstemm merged commit 67cde29 into dev Nov 28, 2018
@mstemm mstemm deleted the mfdii/add_k8s_ns_name branch November 28, 2018 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants