Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing required gen_event virtual methods #480

Merged

Conversation

Projects
None yet
2 participants
@lorenzo-david
Copy link
Contributor

commented Dec 5, 2018

As per draios/sysdig#1275, the gen_event class
mandate the implementation of two new methods.

This change aims to simplify the implementation of a generic event
processing infrastructure, that could handle both sinsp and json
events.

Implementing required gen_event virtual methods
As per draios/sysdig#1275, the gen_event class
mandate the implementation of two new methods.

This change aims to simplify the implementation of a generic event
processing infrastructure, that could handle both sinsp and json
events.
@lorenzo-david

This comment has been minimized.

Copy link
Contributor Author

commented Dec 5, 2018

The build error is:
/home/travis/build/lorenzo-david/falco/userspace/engine/json_evt.h:47:10: error: ‘ESRC_K8S_AUDIT’ was not declared in this scope
return ESRC_K8S_AUDIT;

This is expected. This change is tied to the draios/sysdig PR1275, where the ESRC_K8S_AUDIT is defined.

@mstemm mstemm self-requested a review Dec 12, 2018

@mstemm

mstemm approved these changes Dec 12, 2018

@lorenzo-david lorenzo-david merged commit a78212c into falcosecurity:dev Jan 28, 2019

1 check failed

Travis CI - Pull Request Build Errored
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.