Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Puppet module #537

Merged
merged 3 commits into from Feb 21, 2019

Conversation

Projects
None yet
2 participants
@JPLachance
Copy link
Contributor

commented Feb 15, 2019

Greetings!

I noticed the Puppet module is a little outdated compared to this repository. I also noticed the installation was not working because the DEB repository was not managed by this module. This PR should fix that!

A list of the changes:
* Apply puppet-lint recommendations
* Update the README since the project moved from draios to falcosecurity in GitHub
* Move parameters in their own file
+ Add the DEB repository automatically (based on https://github.com/garethr/garethr-sysdig/blob/master/manifests/install.pp)
+ Add the EPEL repository automatically (based on https://github.com/garethr/garethr-sysdig/blob/master/manifests/install.pp)
+ Add a logrotate configuration
* Update the configuration file with all the latest updates

馃啒 Please note that I'm not a Puppet expert 馃槃

falco-CLA-1.0-contributing-entity: Coveo Solutions Inc.
falco-CLA-1.0-signed-off-by: Jean-Philippe Lachance jplachance@coveo.com

Update the Puppet module:
* Apply puppet-lint recommendations
* Update the README since the project moved from draios to falcosecurity in GitHub
* Move parameters in their own file
+ Add the DEB repository automatically
+ Add the EPEL repository automatically
+ Add a logrotate configuration
* Update the configuration file with all the latest updates

falco-CLA-1.0-contributing-entity: Coveo Solutions Inc.
falco-CLA-1.0-signed-off-by: Jean-Philippe Lachance <jplachance@coveo.com>

@mstemm mstemm self-requested a review Feb 19, 2019

@mstemm
Copy link
Contributor

left a comment

Overall thanks for the contribution! If you could just make the recommended changes so it will install with puppet 4, that would be handy.

JPLachance added some commits Feb 20, 2019

* Set required modules versions properly
* Set dependencies between classes
* Set the class order
* Apply mstemm's code review
* Drop the Puppet 3 support
* Use a working version of puppetlabs-apt
* Use dependencies to be compatible with Puppet 4.7 and above
@mstemm

mstemm approved these changes Feb 21, 2019

@mstemm mstemm merged commit 9c57473 into falcosecurity:dev Feb 21, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

mstemm added a commit that referenced this pull request Feb 21, 2019

Update version to 0.3.0
0.2.0 was released as a part of testing an early version in
#537, and can't be
overwritten, so publish as 0.3.0.

@mstemm mstemm referenced this pull request Feb 21, 2019

Merged

Update version to 0.3.0 #543

mstemm added a commit that referenced this pull request Feb 21, 2019

Update version to 0.3.0 (#543)
0.2.0 was released as a part of testing an early version in
#537, and can't be
overwritten, so publish as 0.3.0.

@JPLachance JPLachance deleted the JPLachance:puppet-module-update branch Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.