Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip incomplete container info for container start #570

Merged
merged 2 commits into from Apr 2, 2019

Conversation

Projects
None yet
1 participant
@mstemm
Copy link
Contributor

commented Apr 2, 2019

In the container_started macro, ensure that the container metadata is
complete after either the container event (very unlikely) or after the
exec of the first process into the container (very likely now that
container metadata fetches are async).

When using these rules with older falco versions, this macro will still
work as the synchronous container metadata fetch will result in a
repository that isn't "incomplete".

@mstemm mstemm referenced this pull request Apr 2, 2019

Merged

Async container info #1326

@mstemm mstemm requested a review from mattpag Apr 2, 2019

@mstemm mstemm force-pushed the skip-incomplete-container-started branch 2 times, most recently from 2cc6c64 to be46944 Apr 2, 2019

Skip incomplete container info for container start
In the container_started macro, ensure that the container metadata is
complete after either the container event (very unlikely) or after the
exec of the first process into the container (very likely now that
container metadata fetches are async).

When using these rules with older falco versions, this macro will still
work as the synchronous container metadata fetch will result in a
repository that isn't "incomplete".

@mstemm mstemm force-pushed the skip-incomplete-container-started branch from be46944 to 5e438d8 Apr 2, 2019

Update test traces to have full container info
Some test trace files used for regression tests didn't have full
container info, and once we started looking for those fields, the tests
stopped working.

So update the traces, and event counts to match.

@mstemm mstemm merged commit 19327e0 into dev Apr 2, 2019

2 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details

@mstemm mstemm deleted the skip-incomplete-container-started branch Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.