Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule update: update image check from rancher_write_conf macro #648

Merged
merged 5 commits into from Jun 6, 2019

Conversation

Projects
None yet
3 participants
@Kaizhe
Copy link
Contributor

commented Jun 5, 2019

No description provided.

@Kaizhe Kaizhe requested review from mstemm, leodido and fntlnz Jun 5, 2019

- macro: rancher_writing_conf
condition: (container.image.repository in (rancher_images)
and proc.name in (lb-controller,rancher-dns,healthcheck,rancher-metadat)
condition: (proc.name in (lb-controller,rancher-dns,healthcheck,rancher-metadat)

This comment has been minimized.

Copy link
@mstemm

mstemm Jun 5, 2019

Contributor

I think the reason I qualified the macro with the image is that the process name 'healthcheck' was really generic. Maybe we could continue to have the image check just for that process?

This comment has been minimized.

Copy link
@Kaizhe

Kaizhe Jun 5, 2019

Author Contributor

I agree healthcheck is too generic. How about removing healthcheck for now.

This comment has been minimized.

Copy link
@Kaizhe

Kaizhe Jun 6, 2019

Author Contributor

added issue: #649

This comment has been minimized.

Copy link
@mstemm

mstemm Jun 6, 2019

Contributor

Thanks! I think you can close the issue now given your later commits.

@mstemm

mstemm approved these changes Jun 6, 2019

Kaizhe added some commits Jun 6, 2019

@Kaizhe Kaizhe changed the title rule update: remove image check from rancher_write_conf macro rule update: update image check from rancher_write_conf macro Jun 6, 2019

@Kaizhe Kaizhe merged commit cd32cce into dev Jun 6, 2019

5 checks passed

Build Build Successful
Details
Run tests All tests passed
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/jenkins/branch This commit looks good
Details

@fntlnz fntlnz deleted the rule-updates-2019-05.v4 branch Jun 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.