Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable event sources #779

Merged
merged 4 commits into from Aug 21, 2019
Merged

Ability to disable event sources #779

merged 4 commits into from Aug 21, 2019

Conversation

@leodido
Copy link
Member

leodido commented Aug 21, 2019

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

NONE

What this PR does / why we need it:

This PR introduces a flag for the Falco CLI, --disable-source=(syscall|k8s_audit).
It modifies the Falco behaviour accordingly (ie., the way it open the inspector).

Which issue(s) this PR fixes:

Fixes #730
Refs #725

Special notes for your reviewer:

The --disable-source flag accepts only the following values: syscall, k8s_audit. Other values are detected and discarded.

This flag can be specified multiple times (for future need).

Nevertheless the user can not disable syscall and k8s_audit event sources at the same time.

Does this PR introduce a user-facing change?:

add flags to disable `syscall` event source or `k8s_audit` event source
@leodido

This comment has been minimized.

Copy link
Member Author

leodido commented Aug 21, 2019

/assign @fntlnz

@leodido leodido requested a review from fntlnz Aug 21, 2019
@poiana poiana added the lgtm label Aug 21, 2019
@poiana

This comment has been minimized.

Copy link

poiana commented Aug 21, 2019

LGTM label has been added.

Git tree hash: 4a4da1b91eaf36838874ba958dd6b8a80b6d7b83

@poiana poiana added the approved label Aug 21, 2019
leodido and others added 3 commits Aug 20, 2019
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: Lorenzo Fonanta <lo@linux.com>
@leodido leodido force-pushed the feat/disable-sources branch from 33c8c07 to 85c29f0 Aug 21, 2019
@poiana poiana removed lgtm approved labels Aug 21, 2019
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: Lorenzo Fontana <lo@linux.com>
@leodido leodido requested a review from fntlnz Aug 21, 2019
@fntlnz
fntlnz approved these changes Aug 21, 2019
@poiana poiana added the lgtm label Aug 21, 2019
@poiana

This comment has been minimized.

Copy link

poiana commented Aug 21, 2019

LGTM label has been added.

Git tree hash: d86b7774b04dca3506a598cbf0002a086172e32e

@poiana

This comment has been minimized.

Copy link

poiana commented Aug 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Aug 21, 2019
@fntlnz fntlnz merged commit 1485359 into dev Aug 21, 2019
6 of 7 checks passed
6 of 7 checks passed
tide Not mergeable. Job Travis CI - Pull Request has not succeeded.
Build Build Successful
Details
Run tests All tests passed
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/jenkins/branch This commit looks good
Details
dco All commits have Signed-off-by
Details
@poiana poiana deleted the feat/disable-sources branch Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.