Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules update: add back rule Delete Bash History for backport compatib… #864

Merged
merged 3 commits into from Oct 3, 2019

Conversation

@Kaizhe
Copy link
Contributor

Kaizhe commented Sep 27, 2019

…ility

Signed-off-by: kaizhe derek0405@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

What this PR does / why we need it:

Add back rule Delete Bash History for backport compatibility. Later on, we should never rename a rule name, instead, create a new version of rule if necessary.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rules: add back rule Delete Bash History for backport compatibility
rules/falco_rules.yaml Show resolved Hide resolved
Kaizhe added 3 commits Sep 27, 2019
…ility

Signed-off-by: kaizhe <derek0405@gmail.com>
Signed-off-by: kaizhe <derek0405@gmail.com>
Signed-off-by: kaizhe <derek0405@gmail.com>
@Kaizhe Kaizhe force-pushed the rule-updates-2019-09.v2 branch from 3ed0e85 to 278390f Sep 30, 2019
@leodido
leodido approved these changes Oct 1, 2019
Copy link
Member

leodido left a comment

LGTM

@poiana poiana added the lgtm label Oct 1, 2019
@poiana

This comment has been minimized.

Copy link

poiana commented Oct 1, 2019

LGTM label has been added.

Git tree hash: ad659cafa87e6e146ab3df73611c52ff3e38611f

@poiana poiana added the approved label Oct 1, 2019
@mstemm
mstemm approved these changes Oct 2, 2019
@poiana

This comment has been minimized.

Copy link

poiana commented Oct 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, mstemm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Kaizhe Kaizhe removed the request for review from fntlnz Oct 2, 2019
@leodido leodido merged commit cdb5d71 into dev Oct 3, 2019
3 of 4 checks passed
3 of 4 checks passed
tide Not mergeable. Should not have do-not-merge/release-note-label-needed label.
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
dco All commits have Signed-off-by
Details
@poiana poiana deleted the rule-updates-2019-09.v2 branch Oct 3, 2019
@fntlnz fntlnz added this to the 0.18.0 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.