Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules update: add calico/node to trusted privileged container list; a… #902

Merged
merged 1 commit into from Oct 25, 2019

Conversation

@Kaizhe
Copy link
Contributor

Kaizhe commented Oct 25, 2019

…dd calico_node_write_envvars macro to exception list of write below etc

Signed-off-by: kaizhe derek0405@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:
Reduce FP

Which issue(s) this PR fixes:

  1. add calico/node to trusted privileged container list
  2. add macro calico_node_write_envvars to exception list of write below etc

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rules: add calico/node to trusted privileged container list
rules: add macro `calico_node_write_envvars` to exception list of write below etc
@poiana poiana added the lgtm label Oct 25, 2019
@poiana

This comment has been minimized.

Copy link

poiana commented Oct 25, 2019

LGTM label has been added.

Git tree hash: e38a06c334b5401ce26004868b2403c16375f984

@poiana poiana added the approved label Oct 25, 2019
…dd calico_node_write_envvars macro to exception list of write below etc

Signed-off-by: kaizhe <derek0405@gmail.com>
@fntlnz fntlnz dismissed their stale review via 9082be2 Oct 25, 2019
@fntlnz fntlnz force-pushed the rule-updates-2019-10.v2 branch from a3e769b to 9082be2 Oct 25, 2019
@poiana poiana removed the approved label Oct 25, 2019
@fntlnz

This comment has been minimized.

Copy link
Member

fntlnz commented Oct 25, 2019

@Kaizhe Thanks for this! I squashed your "minor fix" commit, once it's green we can merge

@fntlnz
fntlnz approved these changes Oct 25, 2019
@poiana

This comment has been minimized.

Copy link

poiana commented Oct 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Oct 25, 2019
@fntlnz fntlnz merged commit b38db99 into dev Oct 25, 2019
3 of 4 checks passed
3 of 4 checks passed
tide Not mergeable. Job Travis CI - Pull Request has not succeeded.
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
dco All commits have Signed-off-by
Details
@poiana poiana deleted the rule-updates-2019-10.v2 branch Oct 25, 2019
@fntlnz fntlnz added this to the 0.18.0 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.