From 214d1fbb932787136d5c0bdca8d535a948e6d20d Mon Sep 17 00:00:00 2001 From: Jason Dellaluce Date: Fri, 29 Sep 2023 12:59:29 +0000 Subject: [PATCH] fix(tests/falco): adapt to new engine version scheme Signed-off-by: Jason Dellaluce --- tests/falco/commands_test.go | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/tests/falco/commands_test.go b/tests/falco/commands_test.go index 73ceb56..c4dc904 100644 --- a/tests/falco/commands_test.go +++ b/tests/falco/commands_test.go @@ -28,6 +28,7 @@ import ( "github.com/falcosecurity/testing/tests/data/rules" "github.com/stretchr/testify/assert" + "github.com/stretchr/testify/require" ) // todo(jasondellaluce): implement tests for the non-covered Falco cmds/args: @@ -217,22 +218,23 @@ func TestFalco_Print_Rules(t *testing.T) { falco.WithArgs("-o", "load_plugins[0]=json"), falco.WithRules(rules.RulesDir000SingleRule, rules.RulesListWithPluginJSON), ) + infos := res.RulesetDescription() assert.NotNil(t, infos) // check required engine version - assert.Equal(t, "11", infos.RequiredEngineVersion) + assert.Equal(t, "0.11.0", infos.RequiredEngineVersion) // check required plugin versions - assert.Len(t, infos.RequiredPluginVersions, 1) + require.Len(t, infos.RequiredPluginVersions, 1) assert.Equal(t, "json", infos.RequiredPluginVersions[0].Name) assert.Equal(t, "0.1.0", infos.RequiredPluginVersions[0].Version) // check list elements - assert.Len(t, infos.Lists, 2) + require.Len(t, infos.Lists, 2) assert.Equal(t, "cat_binaries", infos.Lists[0].Info.Name) - assert.Len(t, infos.Lists[0].Info.Items, 1) + require.Len(t, infos.Lists[0].Info.Items, 1) assert.Equal(t, "cat", infos.Lists[0].Info.Items[0]) assert.True(t, infos.Lists[0].Details.Used) assert.Len(t, infos.Lists[0].Details.Lists, 0) @@ -243,14 +245,14 @@ func TestFalco_Print_Rules(t *testing.T) { assert.Equal(t, "cat_capable_binaries", infos.Lists[1].Info.Name) assert.Len(t, infos.Lists[1].Info.Items, 0) assert.True(t, infos.Lists[1].Details.Used) - assert.Len(t, infos.Lists[1].Details.Lists, 1) + require.Len(t, infos.Lists[1].Details.Lists, 1) assert.Equal(t, "cat_binaries", infos.Lists[1].Details.Lists[0]) assert.Len(t, infos.Lists[1].Details.Plugins, 0) - assert.Len(t, infos.Lists[1].Details.ItemsCompiled, 1) + require.Len(t, infos.Lists[1].Details.ItemsCompiled, 1) assert.Equal(t, "cat", infos.Lists[1].Details.ItemsCompiled[0]) // check macro elements - assert.Len(t, infos.Macros, 1) + require.Len(t, infos.Macros, 1) assert.Equal(t, "is_cat", infos.Macros[0].Info.Name) assert.Equal(t, "proc.name in (cat_capable_binaries)", infos.Macros[0].Info.Condition) @@ -262,12 +264,12 @@ func TestFalco_Print_Rules(t *testing.T) { assert.NotEmpty(t, infos.Macros[0].Details.Events) assert.Len(t, infos.Macros[0].Details.ConditionOperators, 1) assert.Equal(t, "in", infos.Macros[0].Details.ConditionOperators[0]) - assert.Len(t, infos.Macros[0].Details.ConditionFields, 1) + require.Len(t, infos.Macros[0].Details.ConditionFields, 1) assert.Equal(t, "proc.name", infos.Macros[0].Details.ConditionFields[0]) assert.Equal(t, "proc.name in (cat)", infos.Macros[0].Details.ConditionCompiled) // check rule elements - assert.Len(t, infos.Rules, 1) + require.Len(t, infos.Rules, 1) assert.Equal(t, "open_from_cat", infos.Rules[0].Info.Name) assert.Equal(t, `evt.type=open and is_cat and json.value[/test] = "test"`, infos.Rules[0].Info.Condition) @@ -277,13 +279,13 @@ func TestFalco_Print_Rules(t *testing.T) { assert.Equal(t, "Warning", infos.Rules[0].Info.Priority) assert.Equal(t, "syscall", infos.Rules[0].Info.Source) assert.Empty(t, infos.Rules[0].Info.Tags) - assert.Len(t, infos.Rules[0].Details.Plugins, 1) + require.Len(t, infos.Rules[0].Details.Plugins, 1) assert.Equal(t, "json", infos.Rules[0].Details.Plugins[0]) - assert.Len(t, infos.Rules[0].Details.OutputFields, 1) + require.Len(t, infos.Rules[0].Details.OutputFields, 1) assert.Equal(t, "proc.cmdline", infos.Rules[0].Details.OutputFields[0]) assert.Equal(t, infos.Rules[0].Info.Output, infos.Rules[0].Details.OutputCompiled) assert.Len(t, infos.Rules[0].Details.Macros, 1) - assert.Equal(t, "is_cat", infos.Rules[0].Details.Macros[0]) + require.Equal(t, "is_cat", infos.Rules[0].Details.Macros[0]) assert.Len(t, infos.Rules[0].Details.Lists, 0) assert.Len(t, infos.Rules[0].Details.ExceptionFields, 0) assert.Len(t, infos.Rules[0].Details.ExceptionOperators, 0)