Skip to content

Commit ab1cbba

Browse files
author
hhhikr
committed
msvc idiosyncrasy fix
1 parent 1effeab commit ab1cbba

File tree

8 files changed

+26
-12
lines changed

8 files changed

+26
-12
lines changed

ProTrekkr.dsp

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ProTrekkr.ncb

0 Bytes
Binary file not shown.

ProTrekkr.opt

2 KB
Binary file not shown.

release/distrib/history.txt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,16 @@ ProTrekkr releases history
44

55
v2.5.4:
66

7-
- Fixed 2 issues with interpolate commands (it wouldn't work on all effects)
8-
and the whole commmand column is now filled with the first value.
7+
- Fixed 2 issues with interpolate command: it wouldn't work on all effects
8+
and the whole commmand column is now properly filled with the first value.
99
- Input was partly disabled when caps lock was turned on.
1010
- Right mouse button on pattern lines will now increase/decrease value by 8.
1111
- F5 to F9 keys now jumps to 0, 1/4, 2/4, 3/4, 4/4 of the patterns lines.
1212
- Per request, I changed the way the number of patterns is calculated
1313
when saving a song, the tracker now looks for any used (scratch) patterns
1414
and save them within the .ptk module.
15+
- Fixed an issue in digibooster import function which was due
16+
to a MSVC compiler quirk.
1517

1618
v2.5.3:
1719

src/files/mods.cpp

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ unsigned short Getc_Mod_Word()
230230
}
231231

232232
// ------------------------------------------------------
233-
// Retrieve a word from the .mod data
233+
// Retrieve a double word from the .mod data
234234
unsigned int Getc_Mod_Dword()
235235
{
236236
return (int) (Getc_Mod() << 24) +
@@ -459,8 +459,13 @@ void LoadAmigaMod(char *Name, const char *FileName, int channels, int digibooste
459459
// Check bit mask
460460
if(BitMasks[i] & (1 << j))
461461
{
462-
*wDigi_Mod++ = Getc_Mod() | (Getc_Mod() << 8);
463-
*wDigi_Mod++ = Getc_Mod() | (Getc_Mod() << 8);
462+
int value;
463+
value = (int) Getc_Mod();
464+
value |= (int) (Getc_Mod() << 8);
465+
*wDigi_Mod++ = value;
466+
value = (int) Getc_Mod();
467+
value |= (int) (Getc_Mod() << 8);
468+
*wDigi_Mod++ = value;
464469
}
465470
else
466471
{
@@ -482,8 +487,13 @@ void LoadAmigaMod(char *Name, const char *FileName, int channels, int digibooste
482487
wDigi_Mod2 = &wDigi_Mod[j * 2];
483488
for(i = 0; i < 64; i++)
484489
{
485-
wDigi_Mod2[0] = Getc_Mod() | (Getc_Mod() << 8);
486-
wDigi_Mod2[1] = Getc_Mod() | (Getc_Mod() << 8);
490+
int value;
491+
value = (int) Getc_Mod();
492+
value |= (int) (Getc_Mod() << 8);
493+
wDigi_Mod2[0] = value;
494+
value = (int) Getc_Mod();
495+
value |= (int) (Getc_Mod() << 8);
496+
wDigi_Mod2[1] = value;
487497
wDigi_Mod2 += (channels * 2);
488498
}
489499
}

src/plugin/plugin.ncb

0 Bytes
Binary file not shown.

src/plugin/plugin.opt

0 Bytes
Binary file not shown.

src/plugin/plugin.plg

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
--------------------Configuration: plugin - Win32 Release--------------------
77
</h3>
88
<h3>Command Lines</h3>
9-
Creating temporary file "C:\DOCUME~1\franck\LOCALS~1\Temp\RSP5B.tmp" with contents
9+
Creating temporary file "C:\DOCUME~1\franck\LOCALS~1\Temp\RSPEE.tmp" with contents
1010
[
1111
/nologo /MT /W3 /GX /O2 /D "__WIN32__" /D "NDEBUG" /D "_WINDOWS" /D "_MBCS" /D "_USRDLL" /D "PLUGIN_EXPORTS" /D "__WINAMP__" /D "__STAND_ALONE__" /Fp"Release/plugin.pch" /YX /Fo"Release/" /Fd"Release/" /FD /c
1212
"C:\Src\Pc\ptk\src\files\303s.cpp"
@@ -23,8 +23,8 @@ Creating temporary file "C:\DOCUME~1\franck\LOCALS~1\Temp\RSP5B.tmp" with conten
2323
"C:\Src\Pc\ptk\release\distrib\replay\lib\tb_303.cpp"
2424
"C:\Src\Pc\ptk\release\distrib\replay\lib\wavpack.cpp"
2525
]
26-
Creating command line "cl.exe @C:\DOCUME~1\franck\LOCALS~1\Temp\RSP5B.tmp"
27-
Creating temporary file "C:\DOCUME~1\franck\LOCALS~1\Temp\RSP5C.tmp" with contents
26+
Creating command line "cl.exe @C:\DOCUME~1\franck\LOCALS~1\Temp\RSPEE.tmp"
27+
Creating temporary file "C:\DOCUME~1\franck\LOCALS~1\Temp\RSPEF.tmp" with contents
2828
[
2929
kernel32.lib user32.lib ../../zlib.lib msvcrt.lib msacm32.lib dsound.lib /nologo /dll /incremental:no /pdb:"Release/in_ptk.pdb" /machine:I386 /out:"Distrib\in_ptk.dll" /implib:"Release/in_ptk.lib"
3030
.\Release\303s.obj
@@ -41,7 +41,7 @@ kernel32.lib user32.lib ../../zlib.lib msvcrt.lib msacm32.lib dsound.lib /nologo
4141
.\Release\tb_303.obj
4242
.\Release\wavpack.obj
4343
]
44-
Creating command line "link.exe @C:\DOCUME~1\franck\LOCALS~1\Temp\RSP5C.tmp"
44+
Creating command line "link.exe @C:\DOCUME~1\franck\LOCALS~1\Temp\RSPEF.tmp"
4545
<h3>Output Window</h3>
4646
Compiling...
4747
303s.cpp

0 commit comments

Comments
 (0)